Replace fixture protocol in ConfirmationTests with an existential composition of parameterized protocols#1598
Merged
stmontgomery merged 3 commits intoswiftlang:mainfrom Mar 2, 2026
Conversation
…position of parameterized protocols
stmontgomery
requested review from
briancroom and
jerryjrchen
as code owners
stmontgomery
added
the
build
grynspan
requested changes
Feb 27, 2026
Contributor
grynspan
left a comment
grynspan
left a comment
There was a problem hiding this comment.
We only have 26.2 in CI so this change is untestable. Perhaps wait until we can verify it?
…one exhibiting the newer syntax
grynspan
approved these changes
Mar 2, 2026
stmontgomery
deleted the
adopt-constrained-existential-with-protocol-composition
branch
2 tasks
grynspan
added a commit
that referenced
this pull request
Mar 3, 2026
Revert "Replace fixture protocol in ConfirmationTests with an existential composition of parameterized protocols (#1598)" This reverts commit d63cbd4. Resolves rdar://171579639. ### Checklist: - [x] Code and documentation should follow the style of the [Style Guide](https://github.com/apple/swift-testing/blob/main/Documentation/StyleGuide.md). - [x] If public symbols are renamed or modified, DocC references should be updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This modifies a test fixture in
ConfirmationTestsnow that both a Swift language limitation, and an associated runtime bug, have been resolved.The original issue was that the language did not support writing
any RangeExpression<Int> & Sequence<Int> & Sendable, but that was resolved in Swift 6.2 in swiftlang/swift#76705. Once that was resolved, it exposed a runtime bug which would crash when forming a collection of such existential types. That was fixed in swiftlang/swift#85346, and landed in Apple's 26.4 OSes (currently in beta).This PR finally removes the workaround and writes this parameterized test the idiomatic way, using a collection whose element type is a composition of protocols where some are parameterized.
Checklist: