Merged
Conversation
This PR adjusts our logic for test content section discovery on Windows so that the presence of leading and trailing zeroed words is optional. After the next Swift release (6.4), I'll remove the relevant logic in [SwiftRT-COFF.cpp](https://github.com/swiftlang/swift/blob/main/stdlib/public/runtime/SwiftRT-COFF.cpp) that emits this padding for the test section in particular. Then eventually we can remove this padding check outright. A valid type metadata record or test content record won't start with nor end with a fully zeroed `DWORD`/`QWORD`, so I'm not worried about accidentally misreading those records.
grynspan
requested review from
briancroom,
harlanhaskins,
jerryjrchen and
stmontgomery
as code owners
compnerd
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adjusts our logic for test content section discovery on Windows so that the presence of leading and trailing zeroed words is optional.
After the next Swift release (6.4), I'll remove the relevant logic in SwiftRT-COFF.cpp that emits this padding for the test section in particular. Then eventually we can remove this padding check outright.
See also swiftlang/swift#87650.
A valid type metadata record or test content record won't start with nor end with a fully zeroed
DWORD/QWORD, so I'm not worried about accidentally misreading those records.Checklist: