Adopt swift-syntax 5.10. #249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grynspan
requested review from
stmontgomery,
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
stmontgomery
approved these changes
Mar 4, 2024
|
@swift-ci please test |
|
@swift-ci please test Linux |
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
@swift-ci please clean test |
This PR updates our swift-syntax dependency to the 510.0.0 tag.
grynspan
force-pushed
the
jgrynspan/swift-syntax-510
branch
from
e5f8266 to
502321d
Compare
|
@swift-ci please test |
|
@swift-ci please test Linux |
briancroom
approved these changes
Mar 11, 2024
|
This unfortunately makes swift-testing incompatible with any project that depends on swift-syntax 509, either directly or via a dependency/macro library that hasn't been updated. Does swift-testing take advantage of new 510 features, or could it use a more flexible strategy, as described here: https://www.pointfree.co/blog/posts/116-being-a-good-citizen-in-the-land-of-swiftsyntax |
|
Yes, swift-testing takes advantage of swift-syntax 5.10 features. In the future we will adopt swift-syntax 6.0 as seen here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates our swift-syntax dependency to the 510.0.0 tag.
Checklist: