Conversation
…l?`. This PR adds new diagnostics when `#require()` is passed an argument of type `Bool?` because such an argument may be ambiguously interpreted. If the test author writes: ```swift try #require(love?.isFleeting) ``` Do they mean to unwrap the optional boolean value and return it, or do they mean to test if `isFleeting` is true or false? With this change, an expression such as that one that returns a value of type `Bool?` will produce a diagnostic of the form: <SCRN> Resolves rdar://105727852.
grynspan
requested review from
SeanROlszewski,
briancroom,
dennisweissmann,
stmontgomery and
suzannaratcliff
as code owners
Contributor
Author
|
@swift-ci please test |
briancroom
approved these changes
Mar 8, 2024
Contributor
Author
|
@swift-ci please test |
stmontgomery
approved these changes
Mar 8, 2024
dennisweissmann
approved these changes
Mar 8, 2024
Contributor
Author
|
@swift-ci please test |
grynspan
commented
Mar 9, 2024
grynspan
commented
Mar 9, 2024
grynspan
commented
Mar 9, 2024
Contributor
Author
|
@swift-ci please test |
grynspan
deleted the
jgrynspan/105727852-diagnose-ambiguous-require-bool
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds new diagnostics when
#require()is passed an argument of typeBool?because such an argument may be ambiguously interpreted. If the test author writes:Do they mean to unwrap the optional boolean value and return it, or do they mean to test if
isFleetingis true or false?With this change, an expression such as that one that returns a value of type
Bool?will produce a diagnostic of the form:(The diagnostics are presented as fix-its in Xcode.)
Resolves rdar://105727852.
Checklist: