Skip to content

Move Runner and contained symbols to SPI group ForToolsIntegrationOnly. #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 11, 2024
Merged

Move Runner and contained symbols to SPI group ForToolsIntegrationOnly. #278

merged 3 commits into from
Mar 11, 2024

Conversation

grynspan
Copy link
Contributor

@grynspan grynspan commented Mar 11, 2024 •
edited
Loading

This PR moves Runner as well as contained symbols like Runner.Plan to the ForToolsIntegrationOnly SPI groups per the SPI policy outlined here.

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.

@grynspan
Move Runner and contained symbols to SPI group `ForToolsIntegration…
d07d92e 
…Only`.

This PR moves `Runner` as well as contained symbols like `Runner.Plan` to the
`ForToolsIntegrationOnly` SPI groups per the SPI policy outlined
[here](https://github.com/apple/swift-testing/blob/main/Documentation/SPI.md).
@grynspan grynspan added the tools integration Integration of swift-testing into tools/IDEs label Mar 11, 2024
@grynspan grynspan self-assigned this Mar 11, 2024
@grynspan
Copy link
Contributor Author

@swift-ci please test

@grynspan
Copy link
Contributor Author

@swift-ci please test

@grynspan
Copy link
Contributor Author

@swift-ci please clean test

@grynspan
Copy link
Contributor Author

Building at desk, but not in CI. Yay!

@grynspan
Copy link
Contributor Author

@swift-ci please test

1 similar comment
@grynspan
Copy link
Contributor Author

@swift-ci please test

@grynspan grynspan merged commit 3a03d64 into main Mar 11, 2024
@grynspan grynspan deleted the jgrynspan/migrate-runner-spi-group branch March 11, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stmontgomery stmontgomery stmontgomery approved these changes

@briancroom briancroom briancroom approved these changes

@dennisweissmann dennisweissmann Awaiting requested review from dennisweissmann

@SeanROlszewski SeanROlszewski Awaiting requested review from SeanROlszewski

@suzannaratcliff suzannaratcliff Awaiting requested review from suzannaratcliff suzannaratcliff is a code owner

Assignees

@grynspan grynspan

Labels
tools integration Integration of swift-testing into tools/IDEs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grynspan @stmontgomery @briancroom