LoggingScope's task local APIs had incorrect sendable annotations#43
Merged
Conversation
These functions must not be Sendable, this will start failing in future builds. Related to rdar://174026465
ktoso
requested review from
ahoppen,
hamishknight,
owenv and
rintaro
as code owners
Contributor
|
Isn't it a source break if we change the task local APIs this way? |
Contributor
Author
|
It's being discussed how to handle this transition, the annotation was incorrectly accepted and allowed wrong semantics. So far we're leaning to make the change and take the risk of compatibility impact in very few spots. |
Member
|
@ktoso Does the corresponding breaking change in |
Contributor
Author
|
Yeah it will be swiftlang/swift#87612 We've been trying to land this for a while now, I need to update the pr |
Member
|
Just wanted to have the link in this PR, thanks. |
rintaro
approved these changes
Apr 9, 2026
hamishknight
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These functions must not be Sendable, this will start failing in future builds.
Related to rdar://174026465