Bring back Sergio's "Add support for Process stdin stream" #208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemcm
requested review from
abertelrud,
aciidgh,
friedbunny,
neonichu and
tomerd
as code owners
artemcm
added a commit
to artemcm/swift-driver
that referenced
this pull request
Apr 12, 2021
This change builds on swiftlang/swift-tools-support-core#208 to allow forwarding of the driver's Standard Input to a compile job.
artemcm
force-pushed
the
ProcessInputSergio
branch
from
b7c9b44 to
2e6136c
Compare
This reverts commit 81eda02.
artemcm
force-pushed
the
ProcessInputSergio
branch
from
2e6136c to
b7097b0
Compare
artemcm
added a commit
to artemcm/swift-driver
that referenced
this pull request
Apr 12, 2021
This change builds on swiftlang/swift-tools-support-core#208 to allow forwarding of the driver's Standard Input to a compile job. Resolves rdar://76454784
artemcm
added a commit
to artemcm/swift-driver
that referenced
this pull request
Apr 12, 2021
This change builds on swiftlang/swift-tools-support-core#208 to allow forwarding of the driver's Standard Input to a compile job. Resolves rdar://76454784
artemcm
added a commit
to artemcm/swift-driver
that referenced
this pull request
Apr 12, 2021
This change builds on swiftlang/swift-tools-support-core#208 to allow forwarding of the driver's Standard Input to a compile job. Resolves rdar://76454784
artemcm
added a commit
to artemcm/swift-driver
that referenced
this pull request
Apr 12, 2021
This change builds on swiftlang/swift-tools-support-core#208 to allow forwarding of the driver's Standard Input to a compile job. Resolves rdar://76454784
|
@swift-ci please test |
|
@swift-ci please test macOS Platform |
|
macOS testing failing with: cc @shahmishal |
|
Fixed the PATH issue |
|
@swift-ci please test macOS Platform |
Thanks! |
|
@sergiocampama @neonichu, Cross-repository tests in swiftlang/swift#36869 all pass, including the Linux smoke tests, which seems to have caused the revert in #143. Could you please take a look if this is okay to merge? Content-wise, this PR is identical to #122. |
sergiocampama
approved these changes
Apr 13, 2021
artemcm
added a commit
to artemcm/swift-driver
that referenced
this pull request
Apr 14, 2021
This change builds on swiftlang/swift-tools-support-core#208 to allow forwarding of the driver's Standard Input to a compile job. Resolves rdar://76454784
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resurrects @sergiocampama's #122, which we required in order to be able to forward standard input in the new swift-driver to the compile jobs it spawns (swiftlang/swift-driver#595).
The change was previously reverted in #143, due to an error seen on Linux.