Skip to content

TSCBasic: handle empty paths in WindowsPath(validatingRelativePath:)#403

Merged
compnerd merged 3 commits into
swiftlang:mainfrom
compnerd:im-empty-inside
Apr 13, 2023
Merged

TSCBasic: handle empty paths in WindowsPath(validatingRelativePath:)#403
compnerd merged 3 commits into
swiftlang:mainfrom
compnerd:im-empty-inside

Conversation

@compnerd

@compnerd compnerd commented Apr 5, 2023

Copy link
Copy Markdown
Member

We may not invoke fileSystemRepresentation on an empty string as per the API contract for the function. Add guards to prevent that. In order to make this behaviour consistency more visible, reorder the constructors to collate the absolute path and relative path handling.

@compnerd
TSCBasic: handle empty paths in WindowsPath(validatingRelativePath:)
a13b389 
We may not invoke `fileSystemRepresentation` on an empty string as per
the API contract for the function.  Add guards to prevent that.  In
order to make this behaviour consistency more visible, reorder the
constructors to collate the absolute path and relative path handling.
@compnerd

compnerd commented Apr 5, 2023

Copy link
Copy Markdown
Member Author

@swift-ci please test

@compnerd compnerd enabled auto-merge (squash) April 5, 2023 16:03
@compnerd

compnerd commented Apr 5, 2023

Copy link
Copy Markdown
Member Author

@swift-ci please test

@compnerd

compnerd commented Apr 5, 2023

Copy link
Copy Markdown
Member Author

@swift-ci please test macOS platform

@MaxDesiatov

MaxDesiatov commented Apr 5, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

AFAIU macOS job is going to fail until macOS CI nodes are updated to a later version of Xcode that supports Swift 5.7. cc @shahmishal

@etcwilde

etcwilde commented Apr 5, 2023

Copy link
Copy Markdown
Member

macOS Failure:

/Users/ec2-user/jenkins/workspace/pr-swift-tools-support-core-macos/branch-main/swift-package-manager: error: package at '/Users/ec2-user/jenkins/workspace/pr-swift-tools-support-core-macos/branch-main/swift-package-manager' is using Swift tools version 5.7.0 but the installed version is 5.5.0

@etcwilde

etcwilde commented Apr 5, 2023

Copy link
Copy Markdown
Member

AFAIU macOS job is going to fail until macOS CI nodes are updated to a later version of Xcode that supports Swift 5.7. cc @shahmishal

Yeah, that comment looks consistent with the macOS build failure.

@compnerd

compnerd commented Apr 6, 2023

Copy link
Copy Markdown
Member Author

@swift-ci please test Windows platform

@compnerd

compnerd commented Apr 6, 2023

Copy link
Copy Markdown
Member Author

@swift-ci please test macOS platform

@compnerd

compnerd commented Apr 6, 2023

Copy link
Copy Markdown
Member Author

CC: @shahmishal:

/Users/ec2-user/jenkins/workspace/pr-swift-tools-support-core-macos/branch-main/swift-package-manager: error: package at '/Users/ec2-user/jenkins/workspace/pr-swift-tools-support-core-macos/branch-main/swift-package-manager' is using Swift tools version 5.7.0 but the installed version is 5.5.0

@compnerd

compnerd commented Apr 7, 2023

Copy link
Copy Markdown
Member Author

@swift-ci please test Windows platform

@compnerd

compnerd commented Apr 7, 2023

Copy link
Copy Markdown
Member Author

@swift-ci please test macOS platform

@compnerd

compnerd commented Apr 10, 2023

Copy link
Copy Markdown
Member Author

@swift-ci please test Windows platform

@compnerd

compnerd commented Apr 10, 2023

Copy link
Copy Markdown
Member Author

@swift-ci please test macOS platfom

@compnerd

compnerd commented Apr 10, 2023

Copy link
Copy Markdown
Member Author

@swift-ci please test macOS platform

3 similar comments
@compnerd

compnerd commented Apr 10, 2023

Copy link
Copy Markdown
Member Author

@swift-ci please test macOS platform

@compnerd

compnerd commented Apr 11, 2023

Copy link
Copy Markdown
Member Author

@swift-ci please test macOS platform

@compnerd

compnerd commented Apr 11, 2023

Copy link
Copy Markdown
Member Author

@swift-ci please test macOS platform

@MaxDesiatov

MaxDesiatov commented Apr 12, 2023

Copy link
Copy Markdown
Contributor

@swift-ci test macos

1 similar comment
@MaxDesiatov

MaxDesiatov commented Apr 12, 2023

Copy link
Copy Markdown
Contributor

@swift-ci test macos

@compnerd

compnerd commented Apr 12, 2023

Copy link
Copy Markdown
Member Author

@swift-ci please test macOS platform

1 similar comment
@compnerd

compnerd commented Apr 13, 2023

Copy link
Copy Markdown
Member Author

@swift-ci please test macOS platform

@MaxDesiatov

MaxDesiatov commented Apr 13, 2023

Copy link
Copy Markdown
Contributor

@swift-ci test macos

@compnerd compnerd merged commit 4683dfa into swiftlang:main Apr 13, 2023
@compnerd compnerd deleted the im-empty-inside branch April 13, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MaxDesiatov MaxDesiatov MaxDesiatov approved these changes
@neonichu neonichu neonichu approved these changes
@aciidgh aciidgh Awaiting requested review from aciidgh
@abertelrud abertelrud Awaiting requested review from abertelrud
@friedbunny friedbunny Awaiting requested review from friedbunny
@tomerd tomerd Awaiting requested review from tomerd

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@compnerd @MaxDesiatov @etcwilde @neonichu @tristanlabelle