Use a concurrent queue to wait for process completion#450
Merged
Conversation
Calling blocking `waitpid` on Swift concurrency threads can cause freezes for `async` code when spawning too many processes with the existing `Process` API.
MaxDesiatov
requested review from
abertelrud,
neonichu and
tomerd
as code owners
Contributor
Author
|
@swift-ci test |
AndrewHoos
approved these changes
Dec 12, 2023
AndrewHoos
left a comment
AndrewHoos
left a comment
There was a problem hiding this comment.
Looks good. I am just wondering if there is an existing queue we can use
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling blocking
waitpidon Swift concurrency threads can cause freezes forasynccode when spawning too many processes with the existingProcessAPI.Also took this opportunity to group process-related files in the same directory.