Skip to content

TSCBasic: remove some deprecated interfaces in Process#454

Merged
compnerd merged 1 commit into
swiftlang:mainfrom
compnerd:obsoleted
Dec 18, 2023
Merged

TSCBasic: remove some deprecated interfaces in Process#454
compnerd merged 1 commit into
swiftlang:mainfrom
compnerd:obsoleted

Conversation

@compnerd

Copy link
Copy Markdown
Member

These interfaces were deprecated in 2022, remove these now. While there were some instances of the init still in use. Thanks to @MaxDesiatov and @weissi for the help to verify the safe removal of these deprecated interfaces.

Comment thread Sources/TSCBasic/Process/Process.swift
@compnerd

Copy link
Copy Markdown
Member Author

@swift-ci please test Linux platform

These interfaces were deprecated in 2022, remove these now.  While there
were some instances of the `init` still in use.  Thanks to @MaxDesiatov
and @weissi for the help to verify the safe removal of these deprecated
interfaces.
@compnerd

Copy link
Copy Markdown
Member Author

@swift-ci please test

@compnerd compnerd enabled auto-merge (rebase) December 18, 2023 17:54

@MaxDesiatov MaxDesiatov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@MaxDesiatov

Copy link
Copy Markdown
Contributor

@swift-ci test windows

@compnerd

Copy link
Copy Markdown
Member Author

@swift-ci please test Windows platform

@compnerd compnerd merged commit 9dd047d into swiftlang:main Dec 18, 2023
@compnerd compnerd deleted the obsoleted branch December 19, 2023 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants