Skip to content

get_architecture_value and ndk_platform_triple is no longer used in test/lit.cfg and can be removed #63907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
WeZZard opened this issue Feb 25, 2023 · 1 comment · Fixed by #79263 · May be fixed by #63910
Closed

get_architecture_value and ndk_platform_triple is no longer used in test/lit.cfg and can be removed #63907

WeZZard opened this issue Feb 25, 2023 · 1 comment · Fixed by #79263 · May be fixed by #63910
Labels
Android Platform: Android bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. cross-compilation Area → utils: Cross-compilation of project sources test suite Area: test suite

Comments

@WeZZard
Copy link
Contributor

WeZZard commented Feb 25, 2023

Description
I configured pylance for lit config scripts in the test directory and find that in current main branch, at the line 1572 of the file test/lit.cfg there is:

            result = kwards["aarch64"]

which should be:

            result = kwargs["aarch64"]

which make the variable ndk_platform_triple below receives incorrect value.

The variable ndk_platform_triple is introduced in the pull request [android] Modify test scripts for aarch64 and modern NDKs. but the use sites of the variable ndk_platform_triple are removed in the pull request [android] Modify test scripts for aarch64 and modern NDKs. and [android] Update to NDK 23b. Thus the get_architecture_value function and ndk_platform_triple could be removed now.

Environment
swift main branch, test/lit.cfg

@WeZZard WeZZard added bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. triage needed This issue needs more specific labels labels Feb 25, 2023
@finagolfin
Copy link
Member

You are correct. The issue is that this config has not been used in awhile, but the new community Android CI uses it again, swiftlang/swift-community-hosted-continuous-integration#55. We'll look at fixing this alongside #78350, let us know if we forget.

@finagolfin finagolfin added test suite Area: test suite Android Platform: Android cross-compilation Area → utils: Cross-compilation of project sources and removed triage needed This issue needs more specific labels labels Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Platform: Android bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. cross-compilation Area → utils: Cross-compilation of project sources test suite Area: test suite
Projects
None yet
2 participants