[test] Suppresses Pylint warnings in lit config scripts. #63910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WeZZard
requested review from
zoecarver,
hyp,
egorzhdan,
artemcm and
ktoso
as code owners
WeZZard
changed the title
finagolfin
reviewed
Feb 27, 2023
| ndk_platform_tuple = get_architecture_value(armv7="armeabi-v7a", | ||
| aarch64="arm64-v8a") | ||
| ndk_platform_triple = get_architecture_value(armv7="arm-linux-androideabi", | ||
| aarch64="aarch64-linux-android") |
There was a problem hiding this comment.
These NDK deletions are fine, I confirmed that they're unused.
|
@hughbe, I see you originally added the Python linter we still use here, could you review or suggest someone who will? |
|
Hi, there. Please review this commit. With this commit, we can make Pylint/Pylance usable for lit configs. |
|
@etcwilde, just stumbled on this again, maybe you'd be interested in pushing this in? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppresses Pylint/Pylance warnings in lit config scripts which caused by
lit_config,configandSubstituteCapturesis not defined in the script.Moreover, this pull request removes unnecessary code in
test/lit.cfgwhich spotted by Pylance.Resolves #63907