Skip to content

Update CONTRIBUTING.md to include PR process / forking information #72674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adammcarter opened this issue Mar 28, 2024 · 1 comment · May be fixed by #72731
Open

Update CONTRIBUTING.md to include PR process / forking information #72674

adammcarter opened this issue Mar 28, 2024 · 1 comment · May be fixed by #72731
Labels
contributor experience feature A feature request or implementation

Comments

@adammcarter
Copy link

Motivation

Hi all, when making my first contribution to Swift Syntax (🎉) it wasn't quite clear on the process to create PRs within this repo - see the comment from here: swiftlang/swift-syntax#1936 (comment) onwards in that thread.

Proposed solution

From that conversation it was suggested to open an issue to update the CONTRIBUTING.md both in Swift Syntax and here in the Swift repo to include the steps for non-maintainers to open their very own PRs.

The information on this post: swiftlang/swift-syntax#1936 (comment) from @Matejkob was super useful and would be good enough to copy and paste in to the CONTRIBUTING.md for any future travellers too IMO.

Thanks in advance!

Alternatives considered

No response

Additional information

No response

@adammcarter adammcarter added feature A feature request or implementation triage needed This issue needs more specific labels labels Mar 28, 2024
@adammcarter
Copy link
Author

For the sake of alignment and any stepping on toes, it's likely this PR won't be implemented by me until the Swift Syntax equivalent is done where presumably both will have the same content.

The WIP PR for Swift Syntax is here: swiftlang/swift-syntax#2577

@hborla hborla added contributor experience and removed triage needed This issue needs more specific labels labels Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor experience feature A feature request or implementation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants