Updated CONTRIBUTING.md with fork/PR submission info #2577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
reviewed
Mar 29, 2024
There was a problem hiding this comment.
Instead of duplicating Git-related information, I would prefer to link to existing documentation that’s probably better and has more links to dive deeper. GitHub seems to have a fairly good page of how to fork a repo. If you think this page would have helped you as well, I’d prefer to link to that: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/fork-a-repo
To make it clear on how others can contribute to the project there's now a dedicated section on how to raise a PR including a link to GitHub's documentation on forking repos
adammcarter
force-pushed
the
adammcarter/contributing-fork-info
branch
from
3cb2a3a to
4f41657
Compare
Good shout! I've updated the file with your suggestion 👌🏻 |
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make it clear on how others can contribute to the project there's now a dedicated section on how to raise a PR including step by step instructions
From issue #2575