Restore build and install of the swiftImageInspectionShared library #14880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 0c42b57 ("ELF: restructure image metadata registration") removed the swift_install_in_component lines for both swiftImageInspectionStatic and swiftImageInspectionShared libraries, even though only the former library was removed in that change. As a result, the swiftImageInspectionShared was not being built or installed. This should fix SR-7038. rdar://problem/37710244
|
@swift-ci please test Linux platform |
|
This is probably the right thing for 4.1, and we can go with a more complete fix for 5.0. |
|
I checked the build log and confirmed that it is building and installing libswiftImageInspectionShared.a. |
|
@swift-ci please smoke test and merge |
|
@swift-ci please smoke test macOS platform |
This was referenced Mar 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 0c42b57 ("ELF: restructure image metadata registration")
removed the swift_install_in_component lines for both
swiftImageInspectionStatic and swiftImageInspectionShared libraries,
even though only the former library was removed in that change. As a
result, the swiftImageInspectionShared was not being built or
installed. This should fix SR-7038.
rdar://problem/37710244