[5.0] [CSSolver] Use correct locator when matching function result types related to closures #14926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lated to closures Currently we always use 'FunctionResult' as a path element when matching function result types, but closure result type is allowed to be implicitly converted to Void, which means we need to be careful when to use 'FunctionResult' and 'ClosureResult'. Resolves: rdar://problem/37790062 (cherry picked from commit 20019be)
xedin
changed the title
|
@swift-ci please smoke test and merge |
|
@swift-ci please smoke test and merge |
|
@swift-ci please smoke test Linux platform |
|
@shahmishal is there a known problem with Linux CI for 5.0 branch? |
|
@shahmishal @huonw I've created PR to address that #14932 |
|
@swift-ci please smoke test Linux platform |
|
Looks like #14932 fixed it, merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we always use 'FunctionResult' as a path element when matching
function result types, but closure result type is allowed to be implicitly
converted to Void, which means we need to be careful when to use
'FunctionResult' and 'ClosureResult'.
Resolves: rdar://problem/37790062