IRGen: Fix assert #15074
Merged
IRGen: Fix assert #15074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
We only need a contextPtr if the function type requires a context rdar://38241155 SR-7138
aschwaighofer
force-pushed
the
irgen_fix_closure_assert
branch
from
f3c7291 to
f0bf9af
Compare
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
|
Test case here: #15076 |
|
@atrick You should be able to re-apply your SILCombiner change now. At least the IRGen failure should be fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only need a contextPtr if the function type requires a context
rdar://38241155
SR-7138