Change a few functions related to runtime library paths to use the correct architecture specific paths #15560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@compnerd please test |
|
@swift-ci please test and merge |
compnerd
approved these changes
Mar 29, 2018
|
Build failed |
|
@lanza seems like something here is the cause: https://ci.swift.org/job/swift-PR-Linux/3968/consoleFull#5841992143122a513-f36a-4c87-8ed7-cbc36a1ec144 |
|
@compnerd Done. |
|
@swift-ci please test |
|
Build failed |
…rrect architecture specific path Adjust the runtimeLibPath for the GenerixUnix toolchain to use the architecture specific path. Modify the `runtimeLibraryPath` in CompilerInvocation.cpp to use the architecture specific version for non-Darwin platforms. Modify a few tests to agree with these changes.
|
Hmm this failed due to a typo in swiftpm that has since been fixed. |
|
@swift-ci please test linux platform |
|
Build failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust the runtimeLibPath for the GenerixUnix toolchain to use the
architecture specific path.
Modify the
runtimeLibraryPathin CompilerInvocation.cpp to use thearchitecture specific version for non-Darwin platforms.
Modify a few tests to agree with these changes.