Skip to content

[closure-spec] Do not try to process begin_apply. It is not supported now. #19444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

gottesmm
Copy link
Contributor

[closure-spec] Do not try to process begin_apply. It is not supported now.

We were crashing when we saw this.

rdar://44612356

@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

@gottesmm
Copy link
Contributor Author

Ignore the first commit. It is just setting up the FullApplySiteKind.

@gottesmm
Copy link
Contributor Author

Forgot to commit a typo fix...

@gottesmm gottesmm force-pushed the pr-9bb82b4578138006a4705894a87e8a908766feca branch from 9bb82b4 to 158237d Compare September 21, 2018 03:41
@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

4 similar comments
@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

… now.

We were crashing when we saw this.

rdar://44612356
@gottesmm gottesmm force-pushed the pr-9bb82b4578138006a4705894a87e8a908766feca branch from 158237d to e919de9 Compare September 21, 2018 03:42
@gottesmm
Copy link
Contributor Author

Actually, I am going to rebase this on top of master. So only 1 commit now.

@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

3 similar comments
@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

Copy link
Contributor

@aschwaighofer aschwaighofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gottesmm gottesmm merged commit eb7716b into swiftlang:master Sep 21, 2018
@gottesmm gottesmm deleted the pr-9bb82b4578138006a4705894a87e8a908766feca branch September 21, 2018 15:15
lorentey added a commit to lorentey/swift that referenced this pull request Sep 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants