Skip to content

[build-script] Support for Android aarch64 #20082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 27, 2018

Conversation

drodriguez
Copy link
Contributor

Support for Android aarch64 in many parts of the build-script. Most of
the changes are reuse variables/parameters that already existed for
Android ARMv7. There is also a new parameter to specify the ICU
data library, which is used by #19503.

With this one can build either armv7 or aarch64, since building both
at the same time requires more changes like #19432 (and probably
more work to support two set of paths).

Support for Android aarch64 in many parts of the build-script. Most of
the changes are reuse variables/parameters that already existed for
Android ARMv7. There is also a new parameter to specify the ICU
data library, which is used by swiftlang#19503.

With this one can build either armv7 or aarch64, since building both
at the same time requires more changes like swiftlang#19432 (and probably
more work to support two set of paths).
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@compnerd
Copy link
Member

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 555e085

@drodriguez
Copy link
Contributor Author

Doesn’t look like I should have affected DebugInfo/local-vars.swift.gyb and #20195 looks like it disables that test.

@compnerd
Copy link
Member

compnerd commented Nov 5, 2018

@swift-ci please test and merge

1 similar comment
@compnerd
Copy link
Member

@swift-ci please test and merge

@swift-ci swift-ci merged commit ac8b89a into swiftlang:master Nov 27, 2018
@drodriguez drodriguez deleted the android-aarch64-build-script branch January 7, 2019 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants