-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Avoid CFAllocator lookup overhead in String bridging #24000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@swift-ci please smoke benchmark |
Build failed before running benchmark. |
9f51798
to
7587ab7
Compare
@swift-ci please smoke benchmark |
Build failed before running benchmark. |
Yah. I should build it locally before running benchmarks apparently though :D |
7587ab7
to
452efd6
Compare
@swift-ci please smoke benchmark |
Performance: -O
Performance: -Osize
Performance: -Onone
How to read the dataThe tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.If you see any unexpected regressions, you should consider fixing the Noise: Sometimes the performance results (not code size!) contain false Hardware Overview
|
All the regressed tests have nothing to do with the code that changed, so I think this is a win |
@swift-ci please smoke test |
@swift-ci please smoke test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add an assertion in case someone tries to call it with a real allocator and intended it. Otherwise, LGTM
452efd6
to
4366a1a
Compare
@swift-ci please smoke test and merge |
4366a1a
to
584fbfc
Compare
@swift-ci please smoke test and merge |
Fixes rdar://problem/49925943