-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[stdlib] Include POSIXError as part of Glibc #24028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 14, 2019
colemancda
added a commit
to PureSwift/Bluetooth
that referenced
this pull request
Apr 14, 2019
Since it is not compiled with Glibc yet https://bugs.swift.org/browse/SR-10485 swiftlang/swift#24028 swiftlang/swift-corelibs-foundation#2113
colemancda
added a commit
to colemancda/swift-corelibs-foundation
that referenced
this pull request
Apr 14, 2019
@swift-ci please test |
Build failed |
@compnerd Builds fine on Linux, not sure what the issue is with macOS.
|
colemancda
added a commit
to PureSwift/BluetoothLinux
that referenced
this pull request
Apr 15, 2019
@swift-ci please test macOS platform |
colemancda
added a commit
to colemancda/swift-corelibs-foundation
that referenced
this pull request
Apr 16, 2019
POSIXErrorCode is now built as part of Glibc swiftlang/swift#24028
colemancda
added a commit
to colemancda/swift-corelibs-foundation
that referenced
this pull request
Apr 16, 2019
This was referenced Apr 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POSIXErrorCode
is compiled as part of the platform module on Darwin, but not as part of Glibc on Linux and other platforms. This PR makes the platforms consistently definePOSIXErrorCode
which should have been compiling for Linux since 8157194#diff-c86969eead9d9f63ad0faa3e75802e66R268.Resolves SR-10485.