[5.1] Code-completion, indexing, cursor-info, etc. for KeyPath dynamic member lookup #24106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently includes both the implicit references to the subscript(dynamicMember:) and the explicit references to the underlying property/subscript declarations. rdar://49028783
When building the implicit subscript expression, set the "implicit" bit correctly and pass it through in the indexer so that we get implicit refernces to the subscript. This would be useful for e.g. searching for all uses of the dynamic subscript.
Ensure the various entity walkers handle the implicit subscript reference correctly (usually by ignoring it) and fall through to the underlying declarations. rdar://49028895
Looks into the root type of the keypath to find additional members. This does not currently map the type of the completion to the subscript's return type. rdar://49029126 Conflicts: include/swift/Sema/IDETypeChecking.h
…ocation The implicit subscript is not located at the "." instead of the identifier, so update the index test.
This test baked in an incorrect USR from a bug that has since been fixed. But we don't really need to check this anyway, so remove it.
Per review feedback. Also add some test cases that should fail dynamic member lookup.
|
@swift-ci please test |
|
Build failed |
|
Linux failure is while building Foundation: |
|
#24108 should fix the Linux failure |
|
@swift-ci please test Linux |
|
Build failed |
|
@akyrtzi Failure is unrelated (Foundation test). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #24072
Reviewed by: @rintaro @nathawes
Add support for code-completion looking up keypath dynamic members, and cursor-info/indexing walking the underlying decls.
rdar://49028783
rdar://49028895
rdar://49029126