Skip to content

test: loosen the #file, #filePath tests for Windows #28641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 9, 2019

Conversation

compnerd
Copy link
Member

@compnerd compnerd commented Dec 8, 2019

Be more lenient about the path separator. This repairs the tests on
Windows after #25656.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@compnerd
Copy link
Member Author

compnerd commented Dec 8, 2019

@swift-ci please smoke test

@compnerd
Copy link
Member Author

compnerd commented Dec 8, 2019

@swift-ci please test windows platform

@compnerd
Copy link
Member Author

compnerd commented Dec 8, 2019

CC: @brentdax - seems that #25656 added overly strict tests

@compnerd
Copy link
Member Author

compnerd commented Dec 9, 2019

@swift-ci please test Windows platform

@compnerd
Copy link
Member Author

compnerd commented Dec 9, 2019

@swift-ci please smoke test

Be more lenient about the path separator.  This repairs the tests on
Windows after swiftlang#25656.
@compnerd
Copy link
Member Author

compnerd commented Dec 9, 2019

@swift-ci please test Windows platform

@compnerd
Copy link
Member Author

compnerd commented Dec 9, 2019

@swift-ci please smoke test

@compnerd
Copy link
Member Author

compnerd commented Dec 9, 2019

@swift-ci please test windows platform

@compnerd compnerd merged commit 5d2f3e5 into swiftlang:master Dec 9, 2019
@compnerd compnerd deleted the magic-separator branch December 9, 2019 06:06
@beccadax
Copy link
Contributor

Sorry about that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants