ClangImporter: Don't force loading of all superclass members in loadNamedMembers() #29348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…amedMembers() I had to fix a fake module.map in IRGen to avoid some breakage.
slavapestov
commented
Jan 22, 2020
|
|
||
| for (auto *ED : const_cast<ClassDecl *>(CD)->getExtensions()) | ||
| ED->loadAllMembers(); | ||
| auto &ctx = CD->getASTContext(); |
There was a problem hiding this comment.
I think this can actually be replaced with a call to (void) CD->lookupDirect(name). I'm going to test and benchmark both versions before checking this in.
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
CodaFi
reviewed
Jan 22, 2020
| if (ED->hasClangNode() && ED->hasLazyMembers()) { | ||
| auto ci = ctx.getOrCreateLazyIterableContextData( | ||
| ED, /*lazyLoader=*/nullptr); | ||
| if (true || !ci->loader->loadNamedMembers(ED, name, ci->memberData)) |
There was a problem hiding this comment.
Neat debugging trick, but we oughta get these out before this is merged.
There was a problem hiding this comment.
Oh, that wasn't supposed to be in there. It works without the 'true ||' too.
|
#26975 supersedes this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to fix a fake module.map in IRGen to avoid some breakage.