Skip to content

EscapeAnalysis: add support for access markers. #29534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2020
Merged

EscapeAnalysis: add support for access markers. #29534

merged 1 commit into from
Jan 29, 2020

Conversation

atrick
Copy link
Contributor

@atrick atrick commented Jan 29, 2020

This will be critical when OSSA relies on access markers everywhere
and more passes are converted to OSSA.

This will be critical when OSSA relies on access markers everywhere
and more passes are converted to OSSA.
@atrick atrick requested a review from eeckstein January 29, 2020 19:18
@atrick
Copy link
Contributor Author

atrick commented Jan 29, 2020

@swift-ci test

@atrick
Copy link
Contributor Author

atrick commented Jan 29, 2020

@swift-ci benchmark

@swift-ci
Copy link
Contributor

Performance: -O

Regression OLD NEW DELTA RATIO
CharIteration_punctuated_unicodeScalars 440 480 +9.1% 0.92x (?)

Code size: -O

Performance: -Osize

Regression OLD NEW DELTA RATIO
DropLastCountableRange 5 6 +20.0% 0.83x (?)

Code size: -Osize

Performance: -Onone

Code size: -swiftlibs

How to read the data The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.

If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.

Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac mini
  Model Identifier: Macmini8,1
  Processor Name: Intel Core i7
  Processor Speed: 3.2 GHz
  Number of Processors: 1
  Total Number of Cores: 6
  L2 Cache (per Core): 256 KB
  L3 Cache: 12 MB
  Memory: 64 GB

@atrick atrick merged commit 2c39aa1 into swiftlang:master Jan 29, 2020
@atrick atrick deleted the escape-access-marker branch February 26, 2020 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants