Skip to content

[5.2]Revert: [SourceKit] Disable module system headers validation #29556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 31, 2020
Merged

[5.2]Revert: [SourceKit] Disable module system headers validation #29556

merged 2 commits into from
Jan 31, 2020

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Jan 30, 2020 •
edited
Loading

swift-5.2-branch version of #29555. Revert #29202

  • Explanation: Disabling system headers checking for swift modules does affect ClangImporter's equivalent flag -fmodules-validate-system-headers too. We should not disable this.
  • Scode: All SourceKit Request
  • Risk: Low. This just revert a change and back to previous behavior
  • Issue: rdar://problem/59042838
  • Testing: Passed the current regression tests
  • Reviewer: Ben Langmuir (@benlangmuir )

@rintaro rintaro requested a review from a team as a code owner January 30, 2020 23:21
@rintaro
Copy link
Member Author

rintaro commented Jan 30, 2020

@swift-ci Please test

@rintaro
Copy link
Member Author

rintaro commented Jan 31, 2020

@swift-ci Please nominate

@rintaro rintaro merged commit fab20c6 into swiftlang:swift-5.2-branch Jan 31, 2020
@benlangmuir benlangmuir mentioned this pull request Feb 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akyrtzi akyrtzi akyrtzi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rintaro @akyrtzi