[CSSimplify] Increment impact for DefineMemberBasedOnUse when base type is any function type#29795
Merged
hborla merged 2 commits intoFeb 13, 2020
Merged
[CSSimplify] Increment impact for DefineMemberBasedOnUse when base type is any function type#29795hborla merged 2 commits into
hborla merged 2 commits into
Conversation
…se type is any function type
xedin
reviewed
Feb 12, 2020
xedin
left a comment
xedin
left a comment
Contributor
There was a problem hiding this comment.
Thank you! This makes sense, I have left a couple of minor notes inline, let's address those and it would be good to go!
Member
|
Looks great! Thank you for your contribution! |
Member
|
@swift-ci please smoke test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request increments the impact by 10 for DefineMemberBasedOnUse fixes when the base type is any function type.
This allows the constraint system to prefer a case when a member is found and then has an argument to parameter mismatch like in the example in SR-11964.
https://bugs.swift.org/browse/SR-11964
Resolves: SR-11964
Resolves: rdar://problem/58028105