Skip to content

Revert "Use in_guaranteed for let captures" #30340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2020
Merged

Revert "Use in_guaranteed for let captures" #30340

merged 1 commit into from
Mar 11, 2020

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Mar 10, 2020

@rintaro
Copy link
Member Author

rintaro commented Mar 10, 2020

@swift-ci Please ASAN test

@rintaro
Copy link
Member Author

rintaro commented Mar 11, 2020 •
edited
Loading

@meg-gupta I'm going to merge this once the PR test successfully build stdlib.
Holding off until #30342

@rintaro rintaro requested review from meg-gupta and removed request for meg-gupta March 11, 2020 00:09
@atrick
Copy link
Contributor

atrick commented Mar 11, 2020

@meg-gupta Shouldn't this revert go ahead? I thought that #29812 was accidentally merged because it was never rebased and there's no commit message

@meg-gupta
Copy link
Contributor

meg-gupta commented Mar 11, 2020 •
edited
Loading

@atrick It wasn't merged by accident. I did a squash merge and I do see a commit message ?

@atrick
Copy link
Contributor

atrick commented Mar 11, 2020

Never mind. Apparently the original PR was merged correctly. I just expected to see the commits squashed in a rebase.

@rintaro rintaro merged commit 04c20b8 into master Mar 11, 2020
@rintaro rintaro deleted the revert-29812-captureconv branch March 11, 2020 01:35
meg-gupta added a commit to meg-gupta/swift that referenced this pull request Mar 13, 2020
@meg-gupta
Revert "Merge pull request swiftlang#30340 from apple/revert-29812-ca…
a7e8a37 
…ptureconv"

This reverts commit 04c20b8, reversing
changes made to 8e39711.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rintaro @atrick @meg-gupta