[Diagnostics] Audit use of constraint system in diagnostics #31479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…q` to use data from solution
… solution to retrieve fixes
…ed with ASTNode This is useful when diagnostic needs to check something about type variables involved in a particular type e.g. whether type variable has been defaulted.
…ntsFailure::isMisplacedMissingArgument`
…OfReferenceEqualityOperator`
…ing generic arguments
…elpers into `FailureDiagnostic`
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
hborla
approved these changes
May 1, 2020
|
@swift-ci please smoke test macOS platform |
|
@swift-ci please smoke test Windows platform |
|
@swift-ci please smoke test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove last places where diagnostics replied on information from constraint system
and instead adjust them to use solution associated with a fix where possible.