Skip to content

[Test] Generalize api-digester tests to all platforms. #31485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

DougGregor
Copy link
Member

The API digester tests were being run only for macOS, mainly
because they were not using %target-swift consistently. Lift
the unnecessary restriction so we run these tests more widely.

The API digester tests were being run only for macOS, mainly
because they were not using %target-swift consistently. Lift
the unnecessary restriction so we run these tests more widely.
@DougGregor DougGregor requested a review from nkcsgexi May 1, 2020 21:59
@DougGregor
Copy link
Member Author

@swift-ci please test

1 similar comment
@DougGregor
Copy link
Member Author

@swift-ci please test

Copy link
Contributor

@nkcsgexi nkcsgexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@swift-ci
Copy link
Contributor

swift-ci commented May 1, 2020

Build failed
Swift Test Linux Platform
Git Sha - f1fcec1

@DougGregor
Copy link
Member Author

@swift-ci please test

1 similar comment
@DougGregor
Copy link
Member Author

@swift-ci please test

@DougGregor
Copy link
Member Author

@swift-ci please test platform macOS

1 similar comment
@DougGregor
Copy link
Member Author

@swift-ci please test platform macOS

@CodaFi
Copy link
Contributor

CodaFi commented May 1, 2020

@swift-ci test macOS

1 similar comment
@DougGregor
Copy link
Member Author

@swift-ci test macOS

@DougGregor
Copy link
Member Author

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented May 2, 2020

Build failed
Swift Test OS X Platform
Git Sha - f1fcec1

@DougGregor DougGregor merged commit b196ee9 into swiftlang:master May 2, 2020
@DougGregor DougGregor deleted the generalize-api-digester-tests branch June 19, 2020 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants