Skip to content

[SR-12725] Diagnose unhandled generic argument mismatch involving FunctionArgument #31511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

LucianoPAlmeida
Copy link
Contributor

Let's always attempt the fallbacks if we don't handle the locator path specifically.
If even then we can't diagnose, then return false.

cc @xedin :)

Resolves SR-12725.

Copy link
Contributor

@xedin xedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@xedin
Copy link
Contributor

xedin commented May 3, 2020

@swift-ci please smoke test

@xedin xedin merged commit 1f0ecc6 into swiftlang:master May 3, 2020
@LucianoPAlmeida LucianoPAlmeida deleted the SR-12725-diagnostics-generic-argument branch May 4, 2020 19:51
@LucianoPAlmeida
Copy link
Contributor Author

@xedin Can we cherry-pick this to 5.3? :)

@xedin
Copy link
Contributor

xedin commented May 4, 2020

@LucianoPAlmeida Sure! That PR would have to have some additional information in the description though - https://swift.org/blog/5-3-release-process/ (Pull Requests for Release Branch bit).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants