[AutoDiff] Fix @differentiable attribute derivative configurations.
#31524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `AbstractFunctionDecl::getDerivativeFunctionConfigurations`, type-check `@differentiable` attributes. This is important to populate derivative configurations for original functions in other files. Resolves TF-1271. Exposes TF-1272: fix derivative configurations for cross-file `@derivative` attributes. This is a more difficult issue.
|
@swift-ci Please smoke test |
|
macOS CI failed on a LLDB test: Retriggering to see if it's reproducible. |
rxwei
reviewed
May 4, 2020
rxwei
approved these changes
May 4, 2020
|
@swift-ci Please smoke test |
dan-zheng
added a commit
that referenced
this pull request
May 4, 2020
…#31524) In `AbstractFunctionDecl::getDerivativeFunctionConfigurations`, type-check `@differentiable` attributes. This is important to populate derivative configurations for original functions in other files. Resolves TF-1271. Exposes TF-1272: fix derivative configurations for cross-file `@derivative` attributes. This is a more difficult issue.
atrick
added a commit
to atrick/swift
that referenced
this pull request
May 4, 2020
https://bugs.swift.org/browse/SR-12732 3 AutoDiff test failures: crashing in SIL verification Failing Tests (3): 06:26:12 Swift(macosx-x86_64) :: AutoDiff/validation-test/derivative_registration.swift 06:26:12 Swift(macosx-x86_64) :: AutoDiff/validation-test/custom_derivatives.swift 06:26:12 Swift(macosx-x86_64) :: AutoDiff/stdlib/derivative_customization.swift Possibly from: commit 738ef73 Author: Dan Zheng <[email protected]> Date: Mon May 4 00:44:48 2020 -0700 [AutoDiff] Fix `@differentiable` attribute derivative configurations. (swiftlang#31524)
rxwei
pushed a commit
to rxwei/swift
that referenced
this pull request
Jun 3, 2020
…swiftlang#31524) In `AbstractFunctionDecl::getDerivativeFunctionConfigurations`, type-check `@differentiable` attributes. This is important to populate derivative configurations for original functions in other files. Resolves TF-1271. Exposes TF-1272: fix derivative configurations for cross-file `@derivative` attributes. This is a more difficult issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
AbstractFunctionDecl::getDerivativeFunctionConfigurations, type-check@differentiableattributes.This is important to populate derivative configurations for original functions in other files. Otherwise, they will incorrectly be diagnosed with:
Resolves TF-1271.
Exposes TF-1272: fix derivative configurations for cross-file
@derivativeattributes. This is a more difficult issue.