[ownership] Add new pass OwnershipVerifierTextualErrorDumper and use it in ownership verifier FileCheck tests instead of SILVerifier. #31539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it in ownership verifier FileCheck tests instead of SILVerifier. This will make it easier for me with a few further refactors to make the ownership verifier testing mode emit per function error numbers instead of the global error number that it is emitting now. The reason why this is necessary is that today, the verification by -sil-verify-all causes the errors to be emitted. That verification is done on a per value level, rather than a per function level, so it is hard to get per function error numbers without doing unprincipled things like propagating around state saying what the current function being verified is. This pass instead will let me make the error counter be per ErrorBuilder which are created per function. One thing to be aware of is that this /will/ cause SILValue::verifyOwnership to not emit any output when the testing flag is enabled. This is to ensure I only do not get duplicate textual error messages from the SILVerifier.
|
This doesn't actually change any output. Its a pure refactor like action. |
|
@swift-ci smoke test |
|
@swift-ci test windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make it easier for me with a few further refactors to make the
ownership verifier testing mode emit per function error numbers instead of the
global error number that it is emitting now.
The reason why this is necessary is that today, the verification by
-sil-verify-all causes the errors to be emitted. That verification is done on a
per value level, rather than a per function level, so it is hard to get per
function error numbers without doing unprincipled things like propagating around
state saying what the current function being verified is.
This pass instead will let me make the error counter be per ErrorBuilder which
are created per function.
One thing to be aware of is that this /will/ cause SILValue::verifyOwnership to
not emit any output when the testing flag is enabled. This is to ensure I only
do not get duplicate textual error messages from the SILVerifier.