Skip to content

[NFC] GenericSignatureImpl: Spell conformsToProtocol & getConformsTo in terms of requirements #31734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

AnthonyLatsis
Copy link
Collaborator

Make it clear that only abstract conformances are of interest to these methods.

@AnthonyLatsis
Copy link
Collaborator Author

Huh, does git always mark adjacent changes as conflicting?

@AnthonyLatsis AnthonyLatsis force-pushed the gensigimpl-api-cleanup branch from dec02d7 to 8899665 Compare May 12, 2020 19:44
@CodaFi
Copy link
Contributor

CodaFi commented May 13, 2020

You'll need to give this one more rebase after the const-ification patches.

@AnthonyLatsis AnthonyLatsis force-pushed the gensigimpl-api-cleanup branch from 8899665 to 44a92a9 Compare May 14, 2020 20:04
@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please smoke test

@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please smoke test Linux

@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please clean smoke test OS X

@AnthonyLatsis AnthonyLatsis merged commit 643744f into swiftlang:master May 15, 2020
@AnthonyLatsis AnthonyLatsis deleted the gensigimpl-api-cleanup branch May 15, 2020 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants