[build] Pass target argument to the linker if needed #31794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following swiftlang#31125 and swiftlang#31612, `-target` is not added automatically to linker flags when that's needed (e.g. when building for Apple SDKs) -- mimic the logic used to add it for compiler flags. Addresses rdar://63138761
|
@swift-ci please test |
edymtt
changed the title
compnerd
reviewed
May 14, 2020
|
@drexin there’s the thread on the variable/predicate that I’d like to see resolved first. |
|
@swift-ci please test |
|
@compnerd Exactly, that's why I was saying I'd like to wait for you to respond :) |
|
Build failed |
|
@swift-ci please test Windows |
|
Build failed |
edymtt
added a commit
that referenced
this pull request
Jul 1, 2020
As part of this refactor some code touched as part of #31794 to better fit into the work done in #32120 -- in detail * `_add_host_variant_c_compile_link_flags` is now invoked by both add_swift_host_library and add_swift_host_library * `_add_host_variant_c_compile_link_flags` now sets the target in linker arguments when building against Apple SDKs Addresses rdar://64911978
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #31125 and #31612,
-targetis not added automatically tolinker flags when that's needed (e.g. when building for Apple SDKs) --
mimic the logic used to add it for compiler flags.
Addresses rdar://63138761