Skip to content

[ConstraintSystem][NFC] add test cases for argument matching #32103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2020

Conversation

omochi
Copy link
Contributor

@omochi omochi commented May 30, 2020

This patch adds test cases for argument matching.

When I am working for #32082 ,
I need more odd inputs to test behavior.

I extract test cases from there and make it.

To add them into master is useful for review future changes of this area.

@omochi
Copy link
Contributor Author

omochi commented May 30, 2020

@swift-ci please smoke test

@omochi
Copy link
Contributor Author

omochi commented May 31, 2020

@swift-ci please smoke test Linux

Copy link
Contributor

@xedin xedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I think it would be useful to add tests like that for defaulted and variadic arguments as well.

@xedin
Copy link
Contributor

xedin commented Jun 1, 2020

@swift-ci please smoke test Linux platform

@omochi
Copy link
Contributor Author

omochi commented Jun 2, 2020

@xedin OK, I will add it as another patch.

@omochi omochi merged commit 6fac5ae into swiftlang:master Jun 2, 2020
@omochi omochi deleted the add-test-arg-match branch June 2, 2020 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants