[ClangImporter] Make sure that inherited convenience constructors are included in members of IterableDeclContext
#32214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't we have to ensure that this is transitive? We're not inserting this constructor into any of the many tables associated with the subclass. |
It is inserted in the lookup table and |
… included in members of `IterableDeclContext` Previously inherited constructors would be skipped from added in member list, depending on the order of request evaluator calls. This was a regression compared to swift 5.2
akyrtzi
force-pushed
the
clang-include-inherited-convenience-inits-for-members
branch
from
a50b982 to
915e215
Compare
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
akyrtzi
deleted the
clang-include-inherited-convenience-inits-for-members
branch
akyrtzi
added a commit
that referenced
this pull request
Jun 16, 2020
akyrtzi
added a commit
that referenced
this pull request
Jun 16, 2020
…nvenience-inits-for-members [ClangImporter] Follow-up for #32214, fix assertion hit due to missing check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously inherited constructors would be skipped from added in member list, depending on the order of request evaluator calls.
This was a regression compared to swift 5.2