[NFC] CS: Inline a parameter in openUnboundGenericType #32309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
slavapestov
approved these changes
Jun 11, 2020
| @@ -790,8 +791,7 @@ Type ConstraintSystem::openUnboundGenericType( | |||
|
|
|||
| type = type.transform([&](Type type) -> Type { | |||
| if (auto unbound = type->getAs<UnboundGenericType>()) { | |||
| OpenedTypeMap replacements; | |||
| return openUnboundGenericType(unbound, locator, replacements); | |||
| return openUnboundGenericType(unbound, locator); | |||
There was a problem hiding this comment.
Are you sure this is NFC?
There was a problem hiding this comment.
Based on the use it seems to be, replacements are local to a particular type...
There was a problem hiding this comment.
Are you sure this is NFC?
It has to be — there is no recursion.
|
@swift-ci Please test source compatibility |
|
@slavapestov Do you want me to pursue a green Debug build? |
|
NVM, I can see now the build was last successful almost a month ago. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.