-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[NFC] CS: Inline a parameter in openUnboundGenericType #32309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NFC] CS: Inline a parameter in openUnboundGenericType #32309
Conversation
@swift-ci please smoke test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good as long as the tests pass.
@@ -790,8 +791,7 @@ Type ConstraintSystem::openUnboundGenericType( | |||
|
|||
type = type.transform([&](Type type) -> Type { | |||
if (auto unbound = type->getAs<UnboundGenericType>()) { | |||
OpenedTypeMap replacements; | |||
return openUnboundGenericType(unbound, locator, replacements); | |||
return openUnboundGenericType(unbound, locator); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure this is NFC?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the use it seems to be, replacements are local to a particular type...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure this is NFC?
It has to be — there is no recursion.
@swift-ci Please test source compatibility |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@slavapestov Do you want me to pursue a green Debug build? |
NVM, I can see now the build was last successful almost a month ago. |
No description provided.