Skip to content

[NFC] CS: Inline a parameter in openUnboundGenericType #32309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

AnthonyLatsis
Copy link
Collaborator

No description provided.

@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please smoke test

@AnthonyLatsis AnthonyLatsis requested a review from xedin June 11, 2020 01:56
Copy link
Contributor

@slavapestov slavapestov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as long as the tests pass.

@@ -790,8 +791,7 @@ Type ConstraintSystem::openUnboundGenericType(

type = type.transform([&](Type type) -> Type {
if (auto unbound = type->getAs<UnboundGenericType>()) {
OpenedTypeMap replacements;
return openUnboundGenericType(unbound, locator, replacements);
return openUnboundGenericType(unbound, locator);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure this is NFC?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the use it seems to be, replacements are local to a particular type...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure this is NFC?

It has to be — there is no recursion.

@slavapestov
Copy link
Contributor

@swift-ci Please test source compatibility

Copy link
Contributor

@xedin xedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AnthonyLatsis
Copy link
Collaborator Author

@slavapestov Do you want me to pursue a green Debug build?

@AnthonyLatsis
Copy link
Collaborator Author

NVM, I can see now the build was last successful almost a month ago.

@AnthonyLatsis AnthonyLatsis merged commit cdc38da into swiftlang:master Jun 11, 2020
@AnthonyLatsis AnthonyLatsis deleted the cs-openunbound-dead-param branch June 11, 2020 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants