Skip to content

Revert "Add path remapping with -coverage-prefix-map to coverage data" #32433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Revert "Add path remapping with -coverage-prefix-map to coverage data" #32433

wants to merge 1 commit into from

Conversation

compnerd
Copy link
Member

Reverts #32175

@compnerd
Copy link
Member Author

CC: @keith @vedantk - seems that the CI didn't trigger on the request (CC: @shahmishal)

@compnerd
Copy link
Member Author

@swift-ci please smoke test

@kateinoigakukun kateinoigakukun mentioned this pull request Jun 17, 2020
Merged
@keith
Copy link
Member

keith commented Jun 17, 2020

I assume the issue here is relying on $PWD in the tests, working on a fix

@compnerd
Copy link
Member Author

Assuming #32434 works, lets go with that instead of this.

@compnerd compnerd closed this Jun 17, 2020
@compnerd compnerd deleted the revert-32175-ks/coverage-relative branch June 17, 2020 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@compnerd @keith