Skip to content

[TBDGen] NFC: print duplicate symbol name before assertion. #32649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 5, 2020
Merged

[TBDGen] NFC: print duplicate symbol name before assertion. #32649

merged 1 commit into from
Jul 5, 2020

Conversation

dan-zheng
Copy link
Contributor

This facilitates debugging.

Example:

TBDGen duplicate symbol: _$s4main5ClassC6methodyS2fFTq
Assertion failed: (false && "TBDGen symbol appears twice"), function addSymbolInternal, file swift/lib/TBDGen/TBDGen.cpp, line 76.

@dan-zheng
Copy link
Contributor Author

@swift-ci Please smoke test

@dan-zheng
Copy link
Contributor Author

I don't believe this is controversial. Merging now.

@dan-zheng dan-zheng merged commit 7b54e8b into swiftlang:master Jul 5, 2020
@dan-zheng dan-zheng deleted the tbdgen-debug branch July 5, 2020 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dan-zheng