AssociatedTypeInference: Generalize computeFixedTypeWitness to consider type parameters #33886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
slavapestov
approved these changes
Sep 10, 2020
| @@ -809,33 +809,37 @@ AssociatedTypeDecl *AssociatedTypeInference::findDefaultedAssociatedType( | |||
|
|
|||
| Type AssociatedTypeInference::computeFixedTypeWitness( | |||
| AssociatedTypeDecl *assocType) { | |||
| Type resultType; | |||
| auto *const structuralTy = DependentMemberType::get( | |||
| proto->getSelfInterfaceType()->getCanonicalType(), assocType->getName()); | |||
There was a problem hiding this comment.
Does the base actually need to be canonical here?
There was a problem hiding this comment.
No, I figured I'd use a canonical base right away to save on canonicalization on repeated calls to getCanonicalTypeInContext. Does that sound silly? 🙃
There was a problem hiding this comment.
I doubt it will have a performance impact in practice. IMHO it benefits readability to not have unnecessary calls to getCanonicalType(), since they're just noise at that point.
…er type parameters While we're here, remove the return on a null generic signature. The request for the generic signature of a protocol is a trivial computation that is never expected to fail
AnthonyLatsis
force-pushed
the
fixed-means-same-type
branch
from
e4e4c98 to
8cae50a
Compare
|
@swift-ci please smoke test and merge |
|
@swift-ci please smoke test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we're here, remove the return on a null generic signature. The request for
the generic signature of a protocol is a trivial computation that is never expected
to fail.