Skip to content

[Build Script] Pass down a CMake path to swift-driver's build script #33918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
artemcm merged 1 commit into from
Sep 29, 2020
Merged

[Build Script] Pass down a CMake path to swift-driver's build script #33918

artemcm merged 1 commit into from
Sep 29, 2020

Conversation

@artemcm
Copy link
Contributor

@artemcm artemcm commented Sep 11, 2020

No description provided.

@artemcm
Copy link
Contributor Author

artemcm commented Sep 11, 2020

swiftlang/swift-driver#246
@swift-ci smoke test

@artemcm
Copy link
Contributor Author

artemcm commented Sep 11, 2020

swiftlang/swift-driver#246
@swift-ci Please Build Toolchain macOS Platform

@artemcm artemcm force-pushed the install_swift_driver_cmake_path branch from b5a7785 to ca24819 Compare September 11, 2020 21:12
@artemcm
Copy link
Contributor Author

artemcm commented Sep 11, 2020

swiftlang/swift-driver#246
@swift-ci smoke test

@artemcm
Copy link
Contributor Author

artemcm commented Sep 11, 2020

swiftlang/swift-driver#246
@swift-ci Please Build Toolchain macOS Platform

@artemcm
Copy link
Contributor Author

artemcm commented Sep 14, 2020

swiftlang/swift-driver#246
@swift-ci smoke test

@artemcm artemcm force-pushed the install_swift_driver_cmake_path branch from ca24819 to 248b4f2 Compare September 14, 2020 20:46
@artemcm
Copy link
Contributor Author

artemcm commented Sep 14, 2020

swiftlang/swift-driver#246
@swift-ci smoke test OS X platform

1 similar comment
@artemcm
Copy link
Contributor Author

artemcm commented Sep 15, 2020

swiftlang/swift-driver#246
@swift-ci smoke test OS X platform

@artemcm artemcm mentioned this pull request Sep 15, 2020
Merged
@artemcm
Copy link
Contributor Author

artemcm commented Sep 15, 2020

swiftlang/swift-driver#246
@swift-ci smoke test OS X platform

1 similar comment
@artemcm
Copy link
Contributor Author

artemcm commented Sep 15, 2020

swiftlang/swift-driver#246
@swift-ci smoke test OS X platform

@artemcm
Copy link
Contributor Author

artemcm commented Sep 16, 2020

swiftlang/swift-driver#246
@swift-ci Please Build Toolchain macOS Platform

@artemcm
Copy link
Contributor Author

artemcm commented Sep 16, 2020

swiftlang/swift-driver#246
@swift-ci smoke test

2 similar comments
@artemcm
Copy link
Contributor Author

artemcm commented Sep 16, 2020

swiftlang/swift-driver#246
@swift-ci smoke test

@artemcm
Copy link
Contributor Author

artemcm commented Sep 17, 2020

swiftlang/swift-driver#246
@swift-ci smoke test

@artemcm
Copy link
Contributor Author

artemcm commented Sep 17, 2020

swiftlang/swift-driver#246
@swift-ci Please Build Toolchain macOS Platform

@artemcm artemcm marked this pull request as ready for review September 17, 2020 18:23
@artemcm artemcm requested a review from DougGregor September 17, 2020 18:23
@swift-ci
Copy link
Contributor

swift-ci commented Sep 17, 2020

macOS Toolchain
Download Toolchain
Git Sha - 248b4f242017e8f8fc680ca226540027b09523d8

Install command
tar -zxf swift-PR-33918-701-osx.tar.gz --directory ~/

@artemcm artemcm changed the base branch from master to main September 24, 2020 16:05
@artemcm
Copy link
Contributor Author

artemcm commented Sep 24, 2020

swiftlang/swift-driver#246
@swift-ci smoke test

@artemcm
Copy link
Contributor Author

artemcm commented Sep 24, 2020

swiftlang/swift-driver#246
@swift-ci Please Build Toolchain macOS Platform

@artemcm
Copy link
Contributor Author

artemcm commented Sep 24, 2020

swiftlang/swift-driver#246
@swift-ci smoke test

@artemcm
Copy link
Contributor Author

artemcm commented Sep 24, 2020

swiftlang/swift-driver#246
@swift-ci Please Build Toolchain macOS Platform

@swift-ci
Copy link
Contributor

swift-ci commented Sep 24, 2020

macOS Toolchain
Download Toolchain
Git Sha - 248b4f242017e8f8fc680ca226540027b09523d8

Install command
tar -zxf swift-PR-33918-704-osx.tar.gz --directory ~/

@artemcm
Copy link
Contributor Author

artemcm commented Sep 24, 2020

swiftlang/swift-driver#246
@swift-ci smoke test OS X platform

@artemcm artemcm force-pushed the install_swift_driver_cmake_path branch from 248b4f2 to d913fc6 Compare September 25, 2020 15:27
@artemcm
Copy link
Contributor Author

artemcm commented Sep 25, 2020

swiftlang/swift-driver#246
@swift-ci smoke test OS X platform

@artemcm
Copy link
Contributor Author

artemcm commented Sep 25, 2020

swiftlang/swift-driver#246
@swift-ci Please Build Toolchain macOS Platform

1 similar comment
@artemcm
Copy link
Contributor Author

artemcm commented Sep 28, 2020

swiftlang/swift-driver#246
@swift-ci Please Build Toolchain macOS Platform

@artemcm
Copy link
Contributor Author

artemcm commented Sep 28, 2020

swiftlang/swift-driver#246
@swift-ci smoke test OS X platform

@artemcm
Copy link
Contributor Author

artemcm commented Sep 28, 2020

swiftlang/swift-driver#246
@swift-ci smoke test Linux Platform

@artemcm
Copy link
Contributor Author

artemcm commented Sep 28, 2020

swiftlang/swift-driver#246
@swift-ci Please Build Toolchain macOS Platform

@artemcm artemcm requested a review from nkcsgexi September 28, 2020 21:27
nkcsgexi
nkcsgexi approved these changes Sep 28, 2020
View reviewed changes
Copy link
Contributor

@nkcsgexi nkcsgexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this PR finalize rdar://69708243? If so, we could associate the PR with the radar by including the radar number in the PR description.

@artemcm
Copy link
Contributor Author

artemcm commented Sep 28, 2020

Will this PR finalize rdar://69708243? If so, we could associate the PR with the radar by including the radar number in the PR description.

It will be submitted simultaneously with: swiftlang/swift-driver#246. The combination of these PRs will resolve this radar. It is the corresponding swift-driver PR that contains the bulk of the work, and its description mentions this Radar.

@swift-ci
Copy link
Contributor

swift-ci commented Sep 28, 2020

macOS Toolchain
Download Toolchain
Git Sha - d913fc6

Install command
tar -zxf swift-PR-33918-708-osx.tar.gz --directory ~/

@artemcm artemcm merged commit 7dd6080 into swiftlang:main Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nkcsgexi nkcsgexi nkcsgexi approved these changes

@DougGregor DougGregor Awaiting requested review from DougGregor

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@artemcm @swift-ci @nkcsgexi