-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[build-script] Add a flag for sccache #34133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[build-script] Add a flag for sccache #34133
Conversation
This adds a flag to enable sccache in order to simplify the build-script invocation, particularly for new contributors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this!
@swift-ci Python lint |
Thanks! |
@swift-ci Python lint |
@swift-ci smoke test |
Maybe I'm missing something in the PR, but what part of the code is finding the path to |
The toolchains do a generic lazy lookup for tools, so this just adds this line that makes it eligible: _register("sccache", "sccache") |
@swift-ci smoke test |
Potential addition: Should this be checking if |
According to the sccache README, that shouldn't be necessary:
|
Nice, I didn't realize that. We could get rid of the |
@swift-ci please smoke test |
@swift-ci python lint |
|
@swift-ci please smoke test |
@swift-ci python lint |
@swift-ci please smoke test |
@swift-ci please test Windows |
@swift-ci test windows |
This adds a flag to enable sccache in order to simplify the build-script invocation, particularly for new contributors.
The implementation is based on the implementation of the
--distcc
flag.CC @gottesmm