[build] Remove forced tracing of lldb dotest #34167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrian-prantl
approved these changes
Oct 2, 2020
|
@swift-ci smoke test |
|
I wonder if this has any meaningful time savings when running the full test suite. |
I don't know if it's significant, but we are parsing the |
|
@swift-ci smoke test Windows Platform |
kastiglione
force-pushed
the
dl/build-Remove-forced-tracing-of-lldb-dotest
branch
from
74a088e to
573886d
Compare
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
-tfromDOTEST_ARGS. This causes verbose output of lldb tests that can't be overridden when calling dotest directly. It appears the initial use of-twas introduced for a legacy xcodebuild path in #20090, and then the flag got propagated in other dotest related changes.