Skip to content

[AutoDiff] Fix differentiation transform crashers in library evolution mode. #34704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rxwei
Copy link
Contributor

@rxwei rxwei commented Nov 12, 2020

AD-generated data structures (linear map structs and branching trace enums) do not need to be resilient data structures. These decls are missing a @frozen attribute. See test files for reproducers.

Resolves rdar://71319547.

@rxwei
Copy link
Contributor Author

rxwei commented Nov 12, 2020

@swift-ci please test

…n mode.

AD-generated data structures (linear map structs and branching trace enums) do not need to be resilient data structures. These decls ade missing a `@frozen` attribute.

Resolves rdar://71319547.
@rxwei rxwei force-pushed the 71319547-ad-generated-decls-shall-not-be-resilient branch from 63cee29 to 1750171 Compare November 12, 2020 11:30
@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 63cee29b9f535a37143c72872234f2259f00006f

@rxwei
Copy link
Contributor Author

rxwei commented Nov 12, 2020

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 1750171

@rxwei
Copy link
Contributor Author

rxwei commented Nov 12, 2020

@swift-ci please test linux platform

@rxwei rxwei merged commit 517bcc4 into swiftlang:main Nov 12, 2020
@rxwei rxwei deleted the 71319547-ad-generated-decls-shall-not-be-resilient branch November 12, 2020 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants