[5.5][Diagnostics] Fix requirement note to properly handle layout requirements #38137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ents Layout requirement doesn't have a second type since it's always `AnyObject`, requirement failure note should handle that, otherwise in no assertion builds this would crash in diagnostic engine trying to emit the note. Resolves: rdar://79672230 (cherry picked from commit 2b58a75)
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
1 similar comment
|
@swift-ci please test Windows platform |
|
Windows failures are unrelated to the changes in this PR. |
DougGregor
approved these changes
Jun 29, 2021
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #38111
Layout requirement doesn't have a second type since it's always
AnyObject,requirement failure note should handle that, otherwise in no assertion builds
this would crash in diagnostic engine trying to emit the note.
Scope: Invalid overloaded calls where one of the overload choices fails layout (conformance to
AnyObject) constraint.Main Branch PR: [Diagnostics] Fix requirement note to properly handle layout requirements #38111
Resolves: rdar://79672230
Risk: Low
Reviewed By: @hborla
Testing: Regression tests added to the suite
Resolves: rdar://79672230
(cherry picked from commit 2b58a75)