Skip to content

[build] disable failing Android cross-compilation test on macOS #38181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2021

Conversation

finagolfin
Copy link
Member

@finagolfin finagolfin commented Jun 30, 2021

@shahmishal, this should disable the test failure you saw because of #33724, please let me know if it doesn't.

@shahmishal
Copy link
Member

Unfortunately, also seeing the test failing on Intel system too.

Swift(macosx-x86_64) :: BuildSystem/android_cross_compile.test

@finagolfin
Copy link
Member Author

Huh, it passed the Mac CI, so it should work there.

@finagolfin finagolfin changed the title [build] disable failing Android cross-compilation test on Apple Silicon [build] disable failing Android cross-compilation test on macOS Jun 30, 2021
@finagolfin
Copy link
Member Author

Updated to disable on Intel macOS too.

@shahmishal
Copy link
Member

@buttaface thanks!

@shahmishal shahmishal merged commit 8499863 into swiftlang:main Jun 30, 2021
@finagolfin finagolfin deleted the test-fix branch June 30, 2021 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants