[Concurrency] repair cooperative global executor #39092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch guards some includes of libdispatch headers so that platforms that doesn't support libdispatch can build cooperative executor runtime. And fixed missing implementations for cooperative mode.
|
@swift-ci please smoke test |
ktoso
reviewed
Aug 30, 2021
There was a problem hiding this comment.
LGTM, but I wonder if we should add some way to test if this mode works so we don't keep breaking it on accident?
Do we have any way to test such thing @DougGregor ?
ktoso
approved these changes
Aug 30, 2021
|
@ktoso should the lack of tests block this PR from being merged? I'm not sure if there's any other way to test this other than adding Swift for WebAssembly target to the community CI build matrix. This "build configuration" can't be enabled with a driver flag I suppose, and we can't rebuild with different CMake flags on existing platforms, right? |
rjmccall
approved these changes
Aug 31, 2021
|
I have no problem landing this without testing in the short term, but yeah, I think it should be a goal to bring up CI to test the WebAssembly target ASAP. |
MaxDesiatov
pushed a commit
that referenced
this pull request
Sep 7, 2021
This preset will be used by community CI for WebAssembly to ensure [single-threaded-runtime mode won't be broken again](#39092 (comment)) and enable us testing IRGen for WebAssembly in upstream. Note that the current preset doesn't build stdlib for Wasm for now because some essential patches haven't been ported yet and build-script doesn't support it. But that should be enabled after that's supported. This change is a part of SR-15168.
8 tasks
WowbaggersLiquidLunch
pushed a commit
to WowbaggersLiquidLunch/swift
that referenced
this pull request
Mar 31, 2022
`SWIFT_STDLIB_SINGLE_THREADED_RUNTIME` mode has been broken for a long time. This patch guards some includes and use of libdispatch headers so that platforms that doesn't support libdispatch can build cooperative executor runtime. And fixed missing implementations for cooperative mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SWIFT_STDLIB_SINGLE_THREADED_RUNTIMEmode has been broken for a long time.This patch guards some includes and use of libdispatch headers so that platforms
that doesn't support libdispatch can build cooperative executor runtime.
And fixed missing implementations for cooperative mode.
CC: @MaxDesiatov
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.