Skip to content

Add flag -swift-async-framepointer=auto,never,always to control swift extended frame information emission - #39245

Merged
aschwaighofer merged 3 commits into
swiftlang:mainfrom
aschwaighofer:swift_async_function_pointer_flags
Sep 15, 2021
Merged

aschwaighofer merged 3 commits into
swiftlang:mainfrom
aschwaighofer:swift_async_function_pointer_flags

Conversation

@aschwaighofer

Copy link
Copy Markdown
Contributor

On linux we default to disable the extended frame info (since the system
libraries don't support it).

On darwin the default is to automatically choose based on the deployment target.

The Concurrency library explicitly forces extended frame information and the
back deployment library explicitly disables it.

@aschwaighofer

Copy link
Copy Markdown
Contributor Author

test with swiftlang/llvm-project#3245

@swift-ci test

@swift-ci

Copy link
Copy Markdown
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 592704ecffd1f88f1bd02e7bbc80d5ca3cba46d9

@aschwaighofer

Copy link
Copy Markdown
Contributor Author

test with swiftlang/llvm-project#3245

@swift-ci test

@swift-ci

Copy link
Copy Markdown
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 592704ecffd1f88f1bd02e7bbc80d5ca3cba46d9

@aschwaighofer
aschwaighofer force-pushed the swift_async_function_pointer_flags branch from 592704e to fad16c8 Compare September 11, 2021 14:06
@aschwaighofer

Copy link
Copy Markdown
Contributor Author

test with swiftlang/llvm-project#3245

@swift-ci test

@swift-ci

Copy link
Copy Markdown
Contributor

Build failed
Swift Test OS X Platform
Git Sha - fad16c86a61b27db80f8e68edf61f67d0369ed73

@aschwaighofer

Copy link
Copy Markdown
Contributor Author

test with swiftlang/llvm-project#3255

@swift-ci test

 control swift extended frame information emission

On linux we default to disable the extended frame info (since the system
libraries don't support it).

On darwin the default is to automatically choose based on the deployment target.

The Concurrency library explicitly forces extended frame information and the
back deployment library explicitly disables it.
@aschwaighofer
aschwaighofer force-pushed the swift_async_function_pointer_flags branch from fad16c8 to a93f777 Compare September 14, 2021 19:49
@aschwaighofer

Copy link
Copy Markdown
Contributor Author

@swift-ci test

@aschwaighofer
aschwaighofer merged commit cffc1b2 into swiftlang:main Sep 15, 2021
@finagolfin

Copy link
Copy Markdown
Member

This pull breaks building the stdlib with a regular clang, ie not the Swift-forked one, on my Android CI. Since that compatibility has been maintained so far, maybe a new CMake flag can be added to only add flags like this for the Swift-forked clang?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants