Skip to content

Add flag -swift-async-framepointer=auto,never,always to control swift extended frame information emission #39245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

aschwaighofer
Copy link
Contributor

On linux we default to disable the extended frame info (since the system
libraries don't support it).

On darwin the default is to automatically choose based on the deployment target.

The Concurrency library explicitly forces extended frame information and the
back deployment library explicitly disables it.

@aschwaighofer
Copy link
Contributor Author

test with swiftlang/llvm-project#3245

@swift-ci test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 592704ecffd1f88f1bd02e7bbc80d5ca3cba46d9

@aschwaighofer
Copy link
Contributor Author

test with swiftlang/llvm-project#3245

@swift-ci test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 592704ecffd1f88f1bd02e7bbc80d5ca3cba46d9

@aschwaighofer aschwaighofer force-pushed the swift_async_function_pointer_flags branch from 592704e to fad16c8 Compare September 11, 2021 14:06
@aschwaighofer
Copy link
Contributor Author

test with swiftlang/llvm-project#3245

@swift-ci test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - fad16c86a61b27db80f8e68edf61f67d0369ed73

@aschwaighofer
Copy link
Contributor Author

test with swiftlang/llvm-project#3255

@swift-ci test

 control swift extended frame information emission

On linux we default to disable the extended frame info (since the system
libraries don't support it).

On darwin the default is to automatically choose based on the deployment target.

The Concurrency library explicitly forces extended frame information and the
back deployment library explicitly disables it.
@aschwaighofer aschwaighofer force-pushed the swift_async_function_pointer_flags branch from fad16c8 to a93f777 Compare September 14, 2021 19:49
@aschwaighofer
Copy link
Contributor Author

@swift-ci test

@aschwaighofer aschwaighofer merged commit cffc1b2 into swiftlang:main Sep 15, 2021
@finagolfin
Copy link
Member

This pull breaks building the stdlib with a regular clang, ie not the Swift-forked one, on my Android CI. Since that compatibility has been maintained so far, maybe a new CMake flag can be added to only add flags like this for the Swift-forked clang?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants